feat(gateway): add runtime footer turn count - #37406
Open
w3rdist-creator wants to merge 1 commit into
Open
w3rdist-creator wants to merge 1 commit into
w3rdist-creator wants to merge 1 commit into
Conversation
alt-glitch
added
type/feature
teknium1
reviewed
Jul 13, 2026
teknium1
left a comment
teknium1
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the focused runtime-footer addition. The requested capability is still absent on current main: gateway/runtime_footer.py:105-118 recognizes only the existing three fields, and gateway/run.py:11827-11834 supplies no turn count.
Problems
- The new config surface needs current default-config and docs coverage.
hermes_cli/config.py:1922-1925andwebsite/docs/user-guide/configuration.md:1476-1483list onlymodel,context_pct, andcwd. /footer onbuilds its preview throughformat_runtime_footerwithout a count (gateway/slash_commands.py:3073-3078), so afields: [turn_count]configuration would produce no preview.- The gateway target has moved from the PR's old line 9408 to current
gateway/run.py:11820-11839; this needs manual reapplication and a current-path integration test.
Suggested changes
- Salvage the call at the current footer site, cover the final-response path, document
turn_count/turn_limit, and define a preview value or omission rule for turn count.
Automated hermes-sweeper review.
| @@ -115,6 +136,10 @@ def format_runtime_footer( | |||
| rel = _home_relative_cwd(cwd or os.environ.get("TERMINAL_CWD", "")) | |||
Collaborator
There was a problem hiding this comment.
Please also handle the /footer on preview path: it calls format_runtime_footer without turn_count (gateway/slash_commands.py:3073-3078), so configuring only this new field would render an empty preview.
teknium1
added
sweeper:risk-message-delivery
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turn_countfield, rendered asN/limitturn_limitfrom global or per-platform runtime footer config, defaulting to 100Test Plan
python -m pytest tests/gateway/test_runtime_footer.py -q -o 'addopts='